[stable23] Avoid use of iconv to get rid of unicode#29965
Merged
Conversation
Member
Author
|
How to correctly sign-off when manually backporting someone else's commit? 🤔 |
Member
Probably by using |
MichaIng
force-pushed
the
backport/29470/stable23
branch
from
e3a934a to
ddde33f
Compare
Member
Author
|
|
Member
Author
|
Not sure why backportbot failed as I don't see any difference in the code. Let's see whether it works from here. |
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Member
Author
|
Additionally we should manually backport: #29958 |
blizzz
approved these changes
Nov 30, 2021
Using iconv for translit depends upon server configuration, locale, and PHP version. Using htmlentities instead to have a consistent behavior independent of configuration. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Co-authored-by: MichaIng <micha@dietpi.com>
MichaIng
force-pushed
the
backport/29470/stable23
branch
from
ddde33f to
4010e58
Compare
come-nc
approved these changes
Dec 20, 2021
This was referenced Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of: #29470