[stable21] Only recommand for php-sodium on >= PHP 7.4 #28656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because php-sodium will solve the missing PASSWORD_ARGON2I constant problem only on >= php 7.4, previously argon2 wasn't part of the standard extension and was disabled on Centos/RHEL. So installing php-sodium on php 7.2 for example wouldn't hide the message. Tested on Fedora with php 7.4, Centos 7 with php 7.2, Centos 8 with php 7.2 and openSUSE with php 7.4. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloud
bot
requested review from
CarlSchwan,
ChristophWurst,
juliusknorr,
kesselb and
szaimen
szaimen
approved these changes
Aug 31, 2021
MichaIng
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #28332