Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 3, 2021

Pending PRs:

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Aug 3, 2021
@skjnldsv skjnldsv added this to the Nextcloud 21.0.4 milestone Aug 3, 2021
@skjnldsv skjnldsv requested review from a team and LukasReschke August 3, 2021 06:48
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 3, 2021

/compile /

@juliusknorr
Copy link
Member

Bundle fix in #28302 i assume it might be related to the compile bot no longer running node 12?

@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 3, 2021

the compile action is running whatever version is in the package.json.
We don't use the compile bot anymore

@juliusknorr
Copy link
Member

Ok, I guess it is due to https://github.com/nextcloud/server/blob/stable21/package.json#L137 then

@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 3, 2021

Ok, I guess it is due to https://github.com/nextcloud/server/blob/stable21/package.json#L137 then

Shall we update that and CI for 20 and 21 ?

@skjnldsv skjnldsv merged commit c52fea0 into stable21 Aug 3, 2021
@skjnldsv skjnldsv deleted the version/21.0.4/Final branch August 3, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants