Skip to content

[21] dont apply jail search filter is on the root #28235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2021
Merged

[21] dont apply jail search filter is on the root #28235

merged 2 commits into from
Jul 29, 2021

Conversation

@icewind1991
Copy link
Member

Backport of #28175

@icewind1991
add test for searching within a "root jail"
96b9aee 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added this to the Nextcloud 21.0.4 milestone Jul 29, 2021
@icewind1991 icewind1991 force-pushed the jail-search-root-21 branch from 5d4942b to bdee6bd Compare July 29, 2021 11:33
PVince81
PVince81 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested, works

@icewind1991
dont apply jail search filter is on the root
a9fbd0b 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the jail-search-root-21 branch from bdee6bd to a9fbd0b Compare July 29, 2021 12:22
@PVince81
Copy link
Member

@icewind1991 seems you'll need to appease the Oracle:

2021-07-29T11:54:25.3526402Z 1) OCA\Files_Sharing\Tests\CacheTest::testSearchByMime
2021-07-29T11:54:25.3527204Z Failed asserting that 6 matches expected 3.

guessing that there might be a cleanup issue ?

@icewind1991
Copy link
Member Author

icewind1991 commented Jul 29, 2021 •
edited
Loading

@icewind1991 seems you'll need to appease the Oracle:

2021-07-29T11:54:25.3526402Z 1) OCA\Files_Sharing\Tests\CacheTest::testSearchByMime
2021-07-29T11:54:25.3527204Z Failed asserting that 6 matches expected 3.

guessing that there might be a cleanup issue ?

fixed

PVince81
PVince81 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 re-tested, re-works

@miaulalala miaulalala self-requested a review July 29, 2021 14:36
@PVince81 PVince81 merged commit 9353802 into stable21 Jul 29, 2021
@PVince81 PVince81 deleted the jail-search-root-21 branch July 29, 2021 14:37
@PVince81
Copy link
Member

/backport to stable20

@PVince81 PVince81 mentioned this pull request Jul 29, 2021
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 29, 2021
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 3, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@miaulalala miaulalala miaulalala approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud 21.0.4

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @PVince81 @miaulalala