Skip to content

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 28, 2021

Fix #27496

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen szaimen added this to the Nextcloud 23 milestone Jul 28, 2021
@szaimen szaimen requested review from PVince81, Pytal and artonge July 28, 2021 10:59
@szaimen
Copy link
Contributor Author

szaimen commented Jul 28, 2021

Failed test is unrelated, afaics

@szaimen
Copy link
Contributor Author

szaimen commented Jul 28, 2021

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Jul 28, 2021

/backport to stable21

@szaimen
Copy link
Contributor Author

szaimen commented Jul 28, 2021

/backport to stable20

@artonge
Copy link
Contributor

artonge commented Jul 28, 2021

Does this mean that files will always expire and there is no way to keep the files in the trash forever?

@szaimen
Copy link
Contributor Author

szaimen commented Jul 28, 2021

Does this mean that files will always expire and there is no way to keep the files in the trash forever?

Actually, I don't know. lets cc @PVince81 and @icewind1991 on this

@Pytal
Copy link
Member

Pytal commented Jul 29, 2021

@Pytal Pytal changed the title Improve auto expiration hint Improve auto expiration hint for trashbin and file versions Jul 29, 2021
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: Pytal <24800714+Pytal@users.noreply.github.com>
@szaimen szaimen force-pushed the fix/27496/improve-auto-expiration-hint branch from cc4173f to 98102bf Compare August 8, 2021 18:41
@szaimen
Copy link
Contributor Author

szaimen commented Aug 8, 2021

Thanks for the good suggestions @Pytal :)

@szaimen szaimen requested a review from Pytal August 8, 2021 18:42
@szaimen
Copy link
Contributor Author

szaimen commented Aug 8, 2021

Failing test is unrelated

@PVince81
Copy link
Member

PVince81 commented Aug 8, 2021

Does this mean that files will always expire and there is no way to keep the files in the trash forever?

Actually, I don't know. lets cc @PVince81 and @icewind1991 on this

according to config.sample.php, it's possible to disable this with: trashbin_retention_obligation => 'disabled'.
not sure how those settings map to the CLI output

@szaimen
Copy link
Contributor Author

szaimen commented Aug 9, 2021

Thanks for the approval Pytal! :)

The failing test is unrelated, afaics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"No expiry configured." when AUTO is configured

6 participants