Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #27835

@MichaIng
Copy link
Member

MichaIng commented Jul 9, 2021

Failed test doesn't seem related:

--- Failed scenarios:

    /drone/src/tests/acceptance/features/app-files-sharing-link.feature:14

  Scenario: hide download in a public shared link                   # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:14
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I set the download of the shared link as hidden             # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsHidden()
      Share link menu in the details view in Files app could not be found after 100 seconds
      Hide download checkbox input in the details view in Files app could not be found after 100 seconds (NoSuchElementException)
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    Then I see that the download button is not shown                # PublicShareContext::iSeeThatTheDownloadButtonIsNotShown()
    And I see that the Share menu button is not shown               # PublicShareContext::iSeeThatTheShareMenuButtonIsNotShown()

@szaimen szaimen added the 4. to release Ready to be released and/or waiting for tests to finish label Jul 9, 2021
@LukasReschke LukasReschke merged commit 32f0d85 into stable22 Jul 12, 2021
@LukasReschke LukasReschke deleted the backport/27835/stable22 branch July 12, 2021 09:45
@skjnldsv skjnldsv mentioned this pull request Jul 26, 2021
@skjnldsv skjnldsv mentioned this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants