Fix dark theme on public link shares #27854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
added
bug
design
szaimen
requested review from
Pytal,
artonge,
jancborchardt,
juliusknorr,
nickvergessen,
nimishavijay and
skjnldsv
artonge
approved these changes
Jul 7, 2021
szaimen
added
2. developing
This comment has been minimized.
This comment has been minimized.
szaimen
force-pushed
the
fix/27371/fix-dark-theme-public-pages
branch
from
f54b283 to
bca8e83
Compare
szaimen
added
3. to review
This comment has been minimized.
This comment has been minimized.
nickvergessen
previously requested changes
Jul 7, 2021
szaimen
added
2. developing
szaimen
force-pushed
the
fix/27371/fix-dark-theme-public-pages
branch
from
bca8e83 to
f918369
Compare
szaimen
added
3. to review
szaimen
added
2. developing
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
fix/27371/fix-dark-theme-public-pages
branch
from
0a0a608 to
ede5db1
Compare
nickvergessen
added
3. to review
|
Ready to review |
|
/backport to stable22 |
szaimen
commented
Jul 9, 2021
There was a problem hiding this comment.
👍 Works in my testing. Thank you @nickvergessen for fixing this! :)
juliusknorr
approved these changes
Jul 9, 2021
szaimen
added
4. to release
|
/backport to stable21 |
|
/backport to stable20 I hope the JS does not comflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27371
Check the file size and date on a public share