Skip to content

Throttle on public DAV endpoint #27610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2021
Merged

Throttle on public DAV endpoint #27610

merged 2 commits into from
Jun 23, 2021

Conversation

@LukasReschke
Copy link
Member

@LukasReschke LukasReschke commented Jun 22, 2021 •
edited
Loading

We should throttle whenever an invalid request is sent to the public WebDAV endpoint.

To test the throttling:

curl -u "RANDOM1:RANDOM2" -X PROPFIND http://localhost:8081/public.php/webdav

@LukasReschke
Throttle on public DAV endpoint
d6a2f00 
We should throttle whenever an invalid request is sent to the public WebDAV endpoint.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Jun 22, 2021
@LukasReschke LukasReschke added this to the Nextcloud 22 milestone Jun 22, 2021
@LukasReschke
Copy link
Member Author

/backport to stable21

@LukasReschke
Copy link
Member Author

/backport to stable20

@LukasReschke
Copy link
Member Author

/backport to stable19

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 22, 2021
@LukasReschke
Reference correct private variable
4627fe4 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
nickvergessen
nickvergessen approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickvergessen nickvergessen merged commit 092ff40 into master Jun 23, 2021
@nickvergessen nickvergessen deleted the add-throttling-to-public-auth branch June 23, 2021 07:34
This was referenced Jun 23, 2021
Merged
Merged
Merged
@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz blizzz approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

4 participants

@LukasReschke @nickvergessen @ChristophWurst @blizzz