Bump vimeo/psalm from 4.7.2 to 4.8.1

[dependabot-preview]

Bumps vimeo/psalm from 4.7.2 to 4.8.1.

Release notes

Sourced from vimeo/psalm's releases.

Fix baseline functionality

Release 4.8.0 introduced a bug in baseline generation. This release should fix it!

Detect more unused code

Features

New literal-string type

Inspired by the is_literal RFC we've added a new literal-string type.

The type will be most useful to annotate functions and methods that take SQL. In those methods you generally don't want any code that is not part of your app, e.g.

<?php
/** @​param literal-string $sql */
function execute_sql(string $sql, array $params = []): void { }
$id = (string) ($_GET['id'] ?? '');
// passes type checks
execute_sql(
'SELECT * FROM foo WHERE id = :id',
[':id' => $id]
);
// fails
execute_sql(
'SELECT * FROM foo WHERE id = "' .$id . '"'
);

Psalm’s taint analysis can also help detect this general class of issues, but a literal-string type allows the type-checker to provide guarantees much earlier in the process.

Read more in the documentation.

More specific taint analysis for unescaped quotes

htmlentities can be used to strip some harmful characters in strings, but not all of them (by default).

Psalm has a new issue TaintedTextWithQuotes to help detect strings that might not have HTML tags but can have harmful Javascript.

Detect unused return values

When running with the --find-unused-code flag, Psalm already detects a lot of unnecessary code, including unused public and private methods, unused properties and unused variables.

Now Psalm will also flag unused return values — where a function returns something, but nowhere that calls the given function actually uses the returned value.

See the documentation for UnusedReturnValue and PossiblyUnusedReturnValue for more information.

... (truncated)

Commits

• f73f229 Fix #5960 - catch exception when baseline cannot be located
• 0a57c86 Announce removal of deprecated methods (#5956)
• df42172 update documentation about authoring plugins (#5958)
• d4311e3 Fix wrong rdkafka commitAsync type (#5950)
• 3c9476b Prevent infinite loop in case a TClassConstant is expanded to itself (#5951)
• 79478a6 Allow class constant as offset key (#5943)
• 872f1c2 allow Psalter to fix RedundantCast (#5948)
• c2f7422 Prevent crash with non-UTF-8 string
• e552925 Emit separate type of issue when foreach value is unused (#5932)
• b1b1072 Fix formatting
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-bot.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .github/dependabot.yml file in this repo:

• Update frequency
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

[nextcloud-bot]

@dependabot merge

[dependabot-preview]

This repository is now using a version: 2 config so Dependabot Preview can no longer make changes to this pull request. You can close it and let Dependabot re-create it the next time it checks for updates.

[dependabot-preview]

One of your CI runs failed on this pull request, so Dependabot won't merge it.

• static-code-analysis-ocp
• static-code-analysis

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

[artonge]

Tried to make CI happy, but I can't reproduce the psalm error locally 🤔