-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
make Provisioning API aware of multiple mails #27474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3eaac3 to
84d1cd2
Compare
Pytal
reviewed
Jun 11, 2021
3f5a7b0 to
3637af2
Compare
This comment has been minimized.
This comment has been minimized.
085fd99 to
784b61e
Compare
5a6216b to
9a320f1
Compare
Pytal
reviewed
Jun 21, 2021
fb905d4 to
ee5b4ac
Compare
Pytal
reviewed
Jun 22, 2021
e33d30a to
3561025
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bd9dafe to
38a2a6b
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- format as stored previously in oc_accounts table is kept Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- fixes wrong veriable usage also Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
ff99a05 to
19d014f
Compare
19d014f to
ad0a11b
Compare
Pytal
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉
skjnldsv
approved these changes
Jun 30, 2021
|
/backport to stable22 |
nickvergessen
requested changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
pending documentation
This pull request needs an associated documentation update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the provisioning API as following
getUser
endpoint:
ocs/v2.php/cloud/users/2d42e983-a7a8-40b1-8e4a-b8afeb5244240bOriginal response
New, with no additional mail set
New, with one or more additional mail set
getEditableFields(ForUser)
endpoint:
ocs/v2.php/cloud/user/fields/e8a7e882-5c5e-4f61-b6bb-bc5fd9b3cb4bone entry added unconditionally
editUser
endpoint:
ocs/v2.php/cloud/users/2d42e983-a7a8-40b1-8e4a-b8afeb5244240bmethod:
PUTTo add an additional email, just use 'additional_mail' as key.
Deleting and setting scope is not possible with this endpoint as we need the value as reference.
editUserMultiValue
endpoint:
ocs/v2.php/cloud/users/2d42e983-a7a8-40b1-8e4a-b8afeb5244240b/{collectionName}method:
PUTkeyparameter and leave the value empty. Future properties may implement renaming by usingkeyas old value andvalueas new value.Scopesuffix to the collectionName.keyis the mail address,valuethe scope value.contributes to #26866