-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign in form best practice #26408
Sign in form best practice #26408
Conversation
This should enable the registration app to set a new-password autocomplete field.
Hum, this was specifically here so tthat we do not allow the browser's auto-completion. I don't understand what this has to do with the registration app, could you explain the issue a bit further please? :) |
This does not affect autocomplete off setting. If we also set autocomplete=“new-password” in the registration app, then the browsers are able to generate safe new passwords for users and not be confused about the type of input field. |
I have no clue about this tbh. 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me 👍
See https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete for the details
@skjnldsv Maybe look also at this file from owncloud. They are using the same autocomplete fields: |
This comment has been minimized.
This comment has been minimized.
/compile /core/js/dist/ |
/rebase |
/compile amend / |
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
c0df6b7
to
9e10eec
Compare
@kevin147147 please rebase |
obsoloted by #33781 |
This should enable the registration app to set a new-password autocomplete field.