Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in form best practice #26408

Closed
wants to merge 2 commits into from
Closed

Sign in form best practice #26408

wants to merge 2 commits into from

Conversation

kevin147147
Copy link
Contributor

This should enable the registration app to set a new-password autocomplete field.

This should enable the registration app to set a new-password autocomplete field.
@skjnldsv
Copy link
Member

skjnldsv commented Apr 2, 2021

Hum, this was specifically here so tthat we do not allow the browser's auto-completion. I don't understand what this has to do with the registration app, could you explain the issue a bit further please? :)

@kevin147147
Copy link
Contributor Author

kevin147147 commented Apr 2, 2021

This does not affect autocomplete off setting. If we also set autocomplete=“new-password” in the registration app, then the browsers are able to generate safe new passwords for users and not be confused about the type of input field.

@skjnldsv
Copy link
Member

skjnldsv commented Apr 6, 2021

I have no clue about this tbh. 🤷

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin147147
Copy link
Contributor Author

@skjnldsv Maybe look also at this file from owncloud. They are using the same autocomplete fields:
https://github.com/owncloud/web/blob/83bdd1fc5410cdc6e3a3502677c5305eb566fab9/tests/acceptance/pageObjects/ocisLoginPage.js

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews enhancement labels May 26, 2021
@MorrisJobke MorrisJobke added this to the Nextcloud 22 milestone May 26, 2021
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
@blizzz

This comment has been minimized.

@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
59 tasks
@blizzz blizzz mentioned this pull request Jun 16, 2021
45 tasks
@blizzz
Copy link
Member

blizzz commented Jun 16, 2021

/compile /core/js/dist/

@blizzz blizzz mentioned this pull request Jun 23, 2021
39 tasks
@blizzz blizzz modified the milestones: Nextcloud 22, Nextcloud 23 Jun 24, 2021
@szaimen
Copy link
Contributor

szaimen commented Aug 31, 2021

/rebase

@szaimen
Copy link
Contributor

szaimen commented Aug 31, 2021

/compile amend /

Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
Copy link
Contributor

szaimen commented Aug 31, 2021

@kevin147147 please rebase

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 31, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 21, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz
Copy link
Member

blizzz commented Mar 7, 2023

obsoloted by #33781

@blizzz blizzz closed this Mar 7, 2023
@blizzz blizzz removed this from the Nextcloud 26 milestone Mar 7, 2023
@szaimen szaimen deleted the kevin147147-patch-1 branch March 7, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants