Skip to content

Cleaner normalizePath regex #26347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2021
Merged

Cleaner normalizePath regex #26347

merged 1 commit into from
Oct 22, 2021

Conversation

@J0WI
Copy link
Contributor

@J0WI J0WI commented Mar 27, 2021

No description provided.

@J0WI J0WI added the 3. to review Waiting for reviews label Mar 27, 2021
@J0WI J0WI force-pushed the clean-path-regex branch 2 times, most recently from 76b81c6 to e3d5e3a Compare March 27, 2021 19:58
@J0WI
Cleaner normalizePath regex
d58d619 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@J0WI J0WI force-pushed the clean-path-regex branch from e3d5e3a to d58d619 Compare March 27, 2021 20:29
@J0WI J0WI requested review from ChristophWurst and rullzer April 12, 2021 12:33
@ChristophWurst
Copy link
Member

The force is not with me when it comes to regex. Mind shedding some light on why this is cleaner than the old one? :)

@J0WI
Copy link
Contributor Author

J0WI commented Apr 16, 2021

Improving the readability of the regex by using another delimiter and avoid escaping of /. This also adds some tests for edge cases like uneven number of forward slashes and filenames with trailing dots.

ChristophWurst
ChristophWurst approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

@J0WI J0WI added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 26, 2021
@kesselb kesselb added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Apr 27, 2021
@J0WI J0WI requested a review from kesselb April 28, 2021 11:45
@J0WI J0WI added this to the Nextcloud 22 milestone Jun 23, 2021
@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
39 tasks
@blizzz blizzz modified the milestones: Nextcloud 22, Nextcloud 23 Jun 24, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
Merged
@skjnldsv skjnldsv merged commit 0a35937 into nextcloud:master Oct 22, 2021
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 22, 2021
@J0WI J0WI deleted the clean-path-regex branch October 23, 2021 23:52
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

5 participants

@J0WI @ChristophWurst @skjnldsv @blizzz @kesselb