Skip to content

Add X-Accel-Buffering header to downloads #25747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2022
Merged

Add X-Accel-Buffering header to downloads #25747

merged 1 commit into from
Apr 7, 2022

Conversation

Unpublished
Copy link
Contributor

Fixes #25126

@Unpublished Unpublished added the 3. to review Waiting for reviews label Feb 22, 2021
@Unpublished
Copy link
Contributor Author

Unpublished commented Feb 22, 2021 •
edited
Loading

Failed to find where this header should be set for webdav downloads 😓

@Unpublished Unpublished added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 23, 2021
@Unpublished Unpublished added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 23, 2021
@skjnldsv
Copy link
Member

/rebase

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 17, 2022
@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Jan 17, 2022
@Unpublished @skjnldsv
Add X-Accel-Buffering header to downloads
854890a 
Signed-off-by: Unpublished <unpublished@gmx.net>
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
@blizzz blizzz mentioned this pull request Apr 7, 2022
Merged
@blizzz blizzz merged commit fb7f65a into master Apr 7, 2022
@blizzz blizzz deleted the XAccelBuffering branch April 7, 2022 13:08
@welcome
Copy link

welcome bot commented Apr 7, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

Add X-Accel-Buffering by default for downloads

4 participants

@Unpublished @skjnldsv @ChristophWurst @blizzz