Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parameter provided as string not array #25361

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jan 28, 2021

array is enforced through TypeHint

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
Copy link
Member Author

blizzz commented Jan 28, 2021

/backport to stable20

@blizzz
Copy link
Member Author

blizzz commented Jan 28, 2021

/backport to stable19

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈, is there no Psalm available for the ldap methods? cough

@blizzz
Copy link
Member Author

blizzz commented Jan 28, 2021

see_no_evil, is there no Psalm available for the ldap methods? cough

you're asking things. tbh, i did not look into Psalm much yet. Nevertheless I was having a false positive of it in LDAP code. In the Psalm config apps/ is included and there is no special treatment for anything LDAP related.

@rullzer rullzer mentioned this pull request Jan 28, 2021
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants