Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If basic auth provided but invalid fail #23914

Closed

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Nov 5, 2020

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer rullzer added enhancement 2. developing Work in progress labels Nov 5, 2020
@rullzer rullzer added this to the Nextcloud 21 milestone Nov 5, 2020
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the fix/throw_exception_if_basic_auth_provided_but_invalid branch from ba8e208 to d0831b9 Compare November 5, 2020 19:55
@faily-bot
Copy link

faily-bot bot commented Nov 5, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35066: failure

mariadb10.1-php7.3

Show full log
There was 1 error:

1) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testUpdate with data set #0 ('sharedBy', 'shareOwner')
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:865
/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:244
/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:481

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

integration-remote-api

  • build/integration/remoteapi_features/remote.feature:33
Show full log
  Scenario: Get capability of remote server           # /drone/src/build/integration/remoteapi_features/remote.feature:33
[Thu Nov  5 20:24:48 2020] 127.0.0.1:40314 Invalid request (Unsupported SSL request)
[Thu Nov  5 20:24:48 2020] 127.0.0.1:40316 [200]: /status.php
    Given using remote server "REMOTE"                # RemoteContext::selectRemoteInstance()
[Thu Nov  5 20:24:49 2020] 127.0.0.1:40318 [404]: /ocs/v2.php/cloud/users/user0
[Thu Nov  5 20:24:49 2020] 127.0.0.1:40340 [200]: /ocs/v1.php/cloud/users
[Thu Nov  5 20:24:50 2020] 127.0.0.1:40388 [200]: /ocs/v1.php/cloud/users/user0
[Thu Nov  5 20:24:50 2020] 127.0.0.1:40414 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                           # FeatureContext::assureUserExists()
    And using credentials "user0", "invalid"          # RemoteContext::usingCredentials()
[Thu Nov  5 20:24:50 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Thu Nov  5 20:24:50 2020] 127.0.0.1:40436 [401]: /ocs/v2.php/cloud/capabilities
    Then the capability "theming.name" is "Nextcloud" # RemoteContext::hasCapability()
      (OC\ForbiddenException)
[Thu Nov  5 20:24:51 2020] 127.0.0.1:40450 [200]: /ocs/v1.php/cloud/users/user0
[Thu Nov  5 20:24:51 2020] 127.0.0.1:40496 [404]: /ocs/v2.php/cloud/users/user0

This was referenced Dec 14, 2020
@ChristophWurst
Copy link
Member

is this done? anything missing?

This was referenced Dec 28, 2020
@rullzer rullzer modified the milestones: Nextcloud 21, Nextcloud 22 Jan 8, 2021
@MorrisJobke MorrisJobke mentioned this pull request May 20, 2021
@MorrisJobke
Copy link
Member

🏓

@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
98 tasks
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 22, Nextcloud 23 Jun 2, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 21, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz
Copy link
Member

blizzz commented Mar 7, 2023

Closing for inactivity

@blizzz blizzz closed this Mar 7, 2023
@blizzz blizzz removed this from the Nextcloud 26 milestone Mar 7, 2023
@MorrisJobke MorrisJobke deleted the fix/throw_exception_if_basic_auth_provided_but_invalid branch March 7, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants