Skip to content

Do not emit UserCreatedEvent twice #23887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2020
Merged

Do not emit UserCreatedEvent twice #23887

merged 2 commits into from
Nov 5, 2020

Conversation

@7118path
Copy link
Contributor

@7118path 7118path commented Nov 4, 2020 •
edited by ChristophWurst
Loading

no more translation from postCreateUser hook to UserCreatedEvent anymore, as event is already emitted in user manager

Fixes #23797

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews bug labels Nov 4, 2020
@ChristophWurst ChristophWurst added this to the Nextcloud 21 milestone Nov 4, 2020
@ChristophWurst ChristophWurst changed the title fix: no more translation from postCrerateUser hook to UserCreatedEvent Do not emit UserCreatedEvent twice Nov 4, 2020
@ChristophWurst
Copy link
Member

DCO check failed: https://github.com/nextcloud/server/pull/23887/checks?check_run_id=1351716573

Please sign off your commit :)

fix: no more translation from postCreateUser hook to UserCreatedEvent…
ded2acc 
… anymore, as event is already emitted in user manager

Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
@MorrisJobke
Copy link
Member

@ecsecta Mind to also remove the use statement for this at the top of the file (that's the complaining code style about).

@MorrisJobke MorrisJobke mentioned this pull request Nov 4, 2020
Merged
1 task
@7118path
Copy link
Contributor Author

7118path commented Nov 5, 2020

Yup, sorry.

fix: also remove use statement of UserCreatedEvent
a79d7c0 
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
@MorrisJobke
Copy link
Member

Yup, sorry.

Don't worry - that's what we have the CI jobs for. Reminding us of the easy to forget stuff.

@MorrisJobke
Copy link
Member

Static code analysis fail is unrelated. That is from a wrong merge from yesterday.

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 5, 2020
@MorrisJobke MorrisJobke merged commit 0247f22 into nextcloud:master Nov 5, 2020
@welcome
Copy link

welcome bot commented Nov 5, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@MorrisJobke
Copy link
Member

/backport to stable20

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@MorrisJobke
Copy link
Member

Was added in #18028 and #18348. Also the emit does only happen in this one place so there is no need to translate it (for another app for example) anymore.

@MorrisJobke MorrisJobke mentioned this pull request Nov 5, 2020
Merged
@MorrisJobke
Copy link
Member

Backport in #23917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb kesselb approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

UserCreatedEvent emitted twice when creating user via user management webui

4 participants

@7118path @ChristophWurst @MorrisJobke @kesselb