Skip to content

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 3, 2020

⚠️ This backport had conflicts and is incomplete ⚠️ JS compile should fix this - some PHP unit test changes are not in here - most likely because those tests are 20+ only

backport of #23350

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Nov 3, 2020
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 3, 2020
@MorrisJobke
Copy link
Member

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the backport/23350/stable18 branch from 0e1b719 to e4f1fec Compare November 4, 2020 08:00
@MorrisJobke
Copy link
Member

CI says no :(

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 4, 2020
@st3iny st3iny self-assigned this Nov 4, 2020
@st3iny st3iny force-pushed the backport/23350/stable18 branch from e4f1fec to cbfcfd3 Compare November 5, 2020 21:44
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 5, 2020
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the backport/23350/stable18 branch from cbfcfd3 to 19ee083 Compare November 5, 2020 23:06
@faily-bot
Copy link

faily-bot bot commented Nov 6, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35081: failure

handlebars

mysql5.6-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #3 ('/source with space.txt', '/target with space.txt')
Expected /target with space.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that false matches expected 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'.

/drone/src/tests/lib/Files/Storage/Storage.php:207
/drone/src/tests/lib/Files/Storage/Storage.php:262

@rullzer rullzer merged commit 263dc71 into stable18 Nov 6, 2020
@rullzer rullzer deleted the backport/23350/stable18 branch November 6, 2020 07:39
@rullzer rullzer mentioned this pull request Nov 9, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants