Skip to content

[stable18] Fix updates of NULL appconfig values #23643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

[stable18] Fix updates of NULL appconfig values #23643

merged 1 commit into from
Oct 23, 2020

Conversation

@backportbot-nextcloud
Copy link

backport of #23602

@rullzer @backportbot
Fix updates of NULL appconfig values
45aca67 
The comparisson of NULL is a bit special.
So we need to handle this a tad beter else it might not replace NULL
values. or allow you to set NULL values on updates.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.11 milestone Oct 23, 2020
@faily-bot
Copy link

faily-bot bot commented Oct 23, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34481: failure

handlebars

mysql8.0-php7.2

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

mysql5.6-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testDeleteUserGroup with data set #1 ('a', 'b', 'c', 'b', false, false)
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:2320

@MorrisJobke MorrisJobke mentioned this pull request Oct 23, 2020
Closed
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Oct 23, 2020
@MorrisJobke MorrisJobke merged commit 91b778b into stable18 Oct 23, 2020
@MorrisJobke MorrisJobke deleted the backport/23602/stable18 branch October 23, 2020 12:30
@rullzer rullzer mentioned this pull request Nov 9, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 18.0.11

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer @MorrisJobke