Skip to content

[stable18] Bring back the restore share button #23638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

[stable18] Bring back the restore share button #23638

merged 1 commit into from
Oct 23, 2020

Conversation

@backportbot-nextcloud
Copy link

backport of #23630

@PVince81 @backportbot
Bring back the restore share button
1def9a0 
Fix disabled default file action to still use an anchor element, as this
is used in many other places (and potentially apps).

Adjusted anchor style to not look like it's clickable and added extras
to make sure everything inside still looks clickable as before.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.11 milestone Oct 22, 2020
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Oct 22, 2020
@faily-bot
Copy link

faily-bot bot commented Oct 22, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34470: failure

handlebars

mysql5.6-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGetSharedWithGroupWithNode with data set #0 ('home::shareOwner', 'files/test.txt', 'files/test2.txt')
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1190

@MorrisJobke MorrisJobke mentioned this pull request Oct 22, 2020
Closed
@MorrisJobke MorrisJobke merged commit 1b2c66a into stable18 Oct 23, 2020
@MorrisJobke MorrisJobke deleted the backport/23630/stable18 branch October 23, 2020 11:58
@rullzer rullzer mentioned this pull request Nov 9, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@GretaD GretaD Awaiting requested review from GretaD

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 18.0.11

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @skjnldsv @PVince81