Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #23613

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Oct 22, 2020
@faily-bot
Copy link

faily-bot bot commented Oct 22, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34445: failure

acceptance-app-comments

  • tests/acceptance/features/app-comments.feature:271
Show full log
  Scenario: open a search result for a comment in a file                    # /drone/src/tests/acceptance/features/app-comments.feature:271
    Given I am logged in                                                    # LoginPageContext::iAmLoggedIn()
    And I open the details view for "welcome.txt"                           # FileListContext::iOpenTheDetailsViewFor()
    And I open the "Comments" tab in the details view                       # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I create a new comment with "Hello world" as message                # CommentsAppContext::iCreateANewCommentWithAsMessage()
    And I see a comment with "Hello world" as message                       # CommentsAppContext::iSeeACommentWithAsMessage()
    And I create a new folder named "Folder"                                # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                            # FilesAppContext::iCloseTheDetailsView()
    When I search for "hello"                                               # SearchContext::iSearchFor()
    And I open the search result 1                                          # SearchContext::iOpenTheSearchResult()
    Then I see that the details view is open                                # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I see that the file name shown in the details view is "welcome.txt" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -''
      +'welcome.txt'
    And I see a comment with "Hello world" as message                       # CommentsAppContext::iSeeACommentWithAsMessage()
    And I see that the file list is currently in "Home"                     # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
    And I see that the file list contains a file named "welcome.txt"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()

@danxuliu danxuliu added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 22, 2020
@MorrisJobke MorrisJobke merged commit 18cc713 into stable18 Oct 22, 2020
@MorrisJobke MorrisJobke deleted the backport/23613/stable18 branch October 22, 2020 13:58
@rullzer rullzer mentioned this pull request Nov 9, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants