Do not target vue progressbar with server styles #21810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Jul 13, 2020
marcoambrosini
force-pushed
the
do-not-target-vue-progress-bar-with-server-styles
branch
2 times, most recently
from
fc92d17
to
157532d
Compare
juliusknorr
approved these changes
Jul 13, 2020
|
I don't understand why. |
|
So? Are we getting this in? |
|
Sure, I'm not fond of this, but let get this in :) |
skjnldsv
approved these changes
Jul 20, 2020
|
Erhm.. Do you know why tests are failing? |
|
Drone history is gone, try a rebase on master |
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
marcoambrosini
force-pushed
the
do-not-target-vue-progress-bar-with-server-styles
branch
from
157532d
to
dc9d37e
Compare
|
done! |
marcoambrosini
deleted the
do-not-target-vue-progress-bar-with-server-styles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco Ambrosini marcoambrosini@pm.me