Skip to content

Only use background fade if nextcloud blue is set #21198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2020
Merged

Only use background fade if nextcloud blue is set #21198

merged 1 commit into from
Jun 8, 2020

Conversation

@juliusknorr
Copy link
Member

Fixes #19040

This PR ensures that we only use the app icons and faded color in the background if the default #0082C9 and makes the code a bit more structured by moving all background logic to the existing mixins.

@juliusknorr
Only use background fade if nextcloud blue is set
81de9e8 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added this to the Nextcloud 20 milestone Jun 3, 2020
@juliusknorr
Copy link
Member Author

/backport to stable19

@juliusknorr
Copy link
Member Author

/backport to stable18

@juliusknorr juliusknorr mentioned this pull request Jun 3, 2020
Closed
rullzer
rullzer approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer rullzer requested a review from ChristophWurst June 6, 2020 07:44
ChristophWurst
ChristophWurst approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have much a clue of scss, but this makes sense 👍 😁

We could store #0082C9 into a constant $nextcloud-blue or similar to make the code slightly easier to process as a human

@rullzer rullzer merged commit ea53423 into master Jun 8, 2020
@rullzer rullzer deleted the bugfix/19040 branch June 8, 2020 11:44
This was referenced Jun 8, 2020
Merged
Merged
@skjnldsv
Copy link
Member

skjnldsv commented Aug 3, 2020

We could store #0082C9 into a constant $nextcloud-blue or similar to make the code slightly easier to process as a human

If you don't know Nextcloud's hexa by heart, you're not worthy of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@marius-wieschollek marius-wieschollek marius-wieschollek approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: theming

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

make gradient optional

6 participants

@juliusknorr @skjnldsv @rullzer @jancborchardt @ChristophWurst @marius-wieschollek