Rename updatenotifications webpack module to updatenotification #20523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module build name for `updatenotification` is actually `updatenotifications` which can be confusing. It is the only module with a name that is different from the app's name. Signed-off-by: Gary Kim <gary@garykim.dev>
gary-kim
requested review from
ChristophWurst,
juliusknorr,
rullzer and
skjnldsv
|
please cleanup the old one and /compile amend :) |
? nothing really changes build wise |
rullzer
approved these changes
Apr 16, 2020
Ah right, I got confused, ignore my tiredness |
ChristophWurst
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most nitpicky PR I have ever made and I am sorry about that.
The module build name for
updatenotificationis actuallyupdatenotificationswhich can be confusing (it confused me for 5 minutes when I was working on it). It is the only module with a name that is different from the app's name.