Skip to content

Conversation

@kesselb
Copy link
Collaborator

@kesselb kesselb commented Jan 24, 2020

Fix #13647

displayname: results.find(function (group) {
return group.id === groupId;
}).displayname

results.find will return undefined if no group found hence displayname fail. I don't know what's wrong with the indention. ESLint does not complain locally about the changes but the rest of the file seems to be wrong.

@kesselb kesselb added this to the Nextcloud 19 milestone Jan 24, 2020
@kesselb kesselb added 3. to review Waiting for reviews bug labels Jan 24, 2020
@kesselb kesselb requested a review from skjnldsv January 24, 2020 15:38
@kesselb kesselb force-pushed the bug/13647/ignore-delete-groups branch from 4736e72 to fc006d2 Compare February 21, 2020 22:22
This was referenced Apr 4, 2020
This was referenced Apr 15, 2020
@rullzer rullzer mentioned this pull request Apr 23, 2020
11 tasks
@kesselb kesselb linked an issue Apr 23, 2020 that may be closed by this pull request
@kesselb kesselb force-pushed the bug/13647/ignore-delete-groups branch from fc006d2 to 3917dae Compare April 23, 2020 18:51
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation seems off in the js file

@kesselb kesselb force-pushed the bug/13647/ignore-delete-groups branch 2 times, most recently from 576d828 to 8772a1e Compare April 24, 2020 16:03
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the bug/13647/ignore-delete-groups branch from 8772a1e to 16f29d8 Compare April 24, 2020 16:10
@kesselb
Copy link
Collaborator Author

kesselb commented Apr 24, 2020

indentation seems off in the js file

./node_modules/eslint/bin/eslint.js --no-eslintrc --rule 'indent: ['error', 'tab'],' --fix apps/settings/js/settings.js to the rescue ;)

@rullzer rullzer mentioned this pull request Apr 30, 2020
2 tasks
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 6aceb39 into master May 4, 2020
@MorrisJobke MorrisJobke deleted the bug/13647/ignore-delete-groups branch May 4, 2020 08:02
@MorrisJobke
Copy link
Member

/backport to stable18

@MorrisJobke
Copy link
Member

/backport to stable17

@kesselb
Copy link
Collaborator Author

kesselb commented May 4, 2020

Hmm. It seems I lost fc006d2 on rebase 🙈

@MorrisJobke
Copy link
Member

Hmm. It seems I lost fc006d2 on rebase 🙈

New PR :) But I tested and the UI and all still worked. On the next save it will not bet there as well. So this is basically only a cleanup thing.

@kesselb
Copy link
Collaborator Author

kesselb commented May 4, 2020

On the next save it will not bet there as well. So this is basically only a cleanup thing.

Exactly. I will have a look later.

@kesselb kesselb self-assigned this May 4, 2020
@kesselb kesselb removed their assignment May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Javascript error in settings.js function setupGroupsSelect() Exclude groups from sharing v14.06 not listing groups, javascript error

3 participants