Use @nextcloud/paths for file sidebar #18749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary-kim
added
bug
3. to review
gary-kim
requested review from
ChristophWurst,
Mikescops,
kesselb,
rullzer and
skjnldsv
gary-kim
added
2. developing
Mikescops
approved these changes
Jan 8, 2020
Signed-off-by: Gary Kim <gary@garykim.dev>
gary-kim
force-pushed
the
fix/18746/use-encode-path
branch
from
37ec607 to
abb45e2
Compare
gary-kim
added
3. to review
rullzer
approved these changes
Jan 8, 2020
skjnldsv
approved these changes
Jan 8, 2020
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18746
Should have used the
@nextcloud/pathsfunctionencodePathinstead. Causes an issue on some instances. 🙈EDIT: https://drone.nextcloud.com/nextcloud/server/24856/56/4 CI caught it... Why did I not look at that 🤦♂️ .