Wrong email sender fix #18730

[exner104]

Wrong email sender in app sharebymail when sending password to owner fix #18730

[rullzer]

Good catch!

[kesselb]

server/apps/sharebymail/lib/ShareByMailProvider.php

Lines 434 to 442 in 44eba5c

	$instanceName = $this->defaults->getName();
	$senderName = $this->l->t(
	'%1$s via %2$s',
	[
	$initiatorDisplayName,
	$instanceName
	]
	);
	$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);

Probably not bad to have the same sender name as the other email. xyz via nextcloud.

[rullzer]

Good point @kesselb
Could you fix that @exner104 ?

[kesselb]

@rullzer we failed 🙈 \OCP\Util::getDefaultEmailAddress($instanceName) but $instanceName was undefined without the additional senderName logic.

[exner104]

@kesselb indeed I used in my first approch the variables $instanceName and $senderName without initializing them.
With the additional code from your advice these variables are defined, so I think the code is now correct.

[rullzer]

Gave it a quick spin and it works.

@exner104 normally we require commits to be signed off. See https://github.com/nextcloud/server/pull/18733/checks?check_run_id=379067761.
But let me merge this and or your next PR you can :)

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!