Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message if no other users with access are found #18701

Merged

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jan 6, 2020

Fixes #18632
Show a small subtitle if no other users with access are found.

In action:

Peek 2020-01-06 21-51

Fixes #18632
Show a small subtitle if no other users with access are found.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@kesselb
Copy link
Contributor

kesselb commented Jan 6, 2020

Hmm. You already know how many other people have access. Why don't we show this as subtitle otherwise? This would prevent this little jump. Misread the code ;)

@rullzer
Copy link
Member Author

rullzer commented Jan 6, 2020

Yeah the title jump is not ideal. But good enough for a quick fix.
@nextcloud/designers for better ideas for 18.0.1 ;)

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@rullzer rullzer merged commit 33039a4 into master Jan 7, 2020
@rullzer rullzer deleted the fix/18632/show_info_when_no_others_with_access_found branch January 7, 2020 09:27
@rullzer rullzer mentioned this pull request Jan 7, 2020
1 task
@jancborchardt
Copy link
Member

@nextcloud/designers for better ideas for 18.0.1 ;)

  • Show the subtitle directly
  • Don’t even show the triangle toggle on the right if there’s no others with access

@rullzer
Copy link
Member Author

rullzer commented Jan 8, 2020

@nextcloud/designers for better ideas for 18.0.1 ;)

* Show the subtitle directly

* Don’t even show the triangle toggle on the right if there’s no others with access

We can't do that. The toggle triggers a request to the backend. And since this can be very costly. We don't want to do it on all openings of the sidebar.

@jancborchardt
Copy link
Member

Ok, then different proposal:
If there are no others with access, on opening the "Others with access" menu, show an entry like a person entry saying:

No others with access
People with access to parent folders will show up here

@wiswedel
Copy link
Contributor

wiswedel commented Jan 8, 2020

If there are no others with access, on opening the "Others with access" menu, show an entry like a person entry saying:

No others with access
People with access to parent folders will show up here

I find that very user friendly and self-documenting

@rullzer
Copy link
Member Author

rullzer commented Jan 8, 2020

@jancborchardt fine by me. Please fill an issue. And we'll see if we can tackle it for 18. Or if it has to wait for 18.0.1 because of time constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[18beta4] [Others with access] bad UX on empty list
5 participants