Skip to content

Conversation

@juliusknorr
Copy link
Member

Fixes error messages that were caused by existing workflow rules from before 18 that do have an empty string as event names set and therefore cause json_decode to return null.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 6, 2019
@rullzer rullzer merged commit 6caec49 into master Dec 6, 2019
@rullzer rullzer deleted the bugfix/noid/workflow-eventnames-fallback branch December 6, 2019 10:36
@rullzer rullzer mentioned this pull request Dec 11, 2019
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants