Move overwritehost check to isTrustedDomain #18184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
approved these changes
Dec 2, 2019
ChristophWurst
approved these changes
Dec 2, 2019
|
/backport to stable17 |
|
/backport to stable16 |
nickvergessen
added
2. developing
juliusknorr
force-pushed
the
bugfix/noid/is-trusted-domain
branch
2 times, most recently
from
2faa50b to
3eb0755
Compare
juliusknorr
added
4. to release
|
Let's wait for CI again but I could not see any related failure anymore |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
force-pushed
the
bugfix/noid/is-trusted-domain
branch
from
3eb0755 to
d05f131
Compare
|
backport to stable17 in #18306 |
|
backport to stable16 in #18308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the trusted domain check in base.php might succeed while calling isTrustedDomain returns false