Accept incoming shares in integration tests #18031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This makes possible to use steps that reference the last share, which will be needed to accept pending shares. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Now all incoming shares need to be explicitly accepted before being able to use the shared file or get information about a reshare (although getting the information of the incoming share is possible before accepting it). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
rullzer
approved these changes
Nov 20, 2019
skjnldsv
approved these changes
Nov 20, 2019
ChristophWurst
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #16828
Besides the integration tests that were failing I have fixed too some that were silently broken (for example, after the behaviour change the orphaned shares test passed anyway, but as the share was not accepted it was not testing anything because the file did not exist). There are surely some left, though. I guess that we will find them... eventually :-P
Also the integration tests should be extended to explicitly check the new behaviour, but... something for the future too ;-)