Skip to content

Convert more columns to bigint #18004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2019
Merged

Convert more columns to bigint #18004

merged 1 commit into from
Nov 20, 2019

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Nov 19, 2019

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer rullzer added enhancement 3. to review Waiting for reviews labels Nov 19, 2019
@rullzer rullzer added this to the Nextcloud 18 milestone Nov 19, 2019
georgehrke
georgehrke approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested and works 👍

We might want to consider renaming occ db:convert-filecache-bigint in the future, since it's no longer only about the file-cache

@georgehrke
Copy link
Member

@rullzer Backport?

@rullzer
Copy link
Member Author

rullzer commented Nov 19, 2019

/backport to stable17

@rullzer
Copy link
Member Author

rullzer commented Nov 19, 2019

/backport to stable16

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 19, 2019
@rullzer
Convert more columns to bigint
decdb6b 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the enh/more_bigint_columns branch from fddb147 to decdb6b Compare November 20, 2019 18:31
@rullzer rullzer merged commit e358d79 into master Nov 20, 2019
@rullzer rullzer deleted the enh/more_bigint_columns branch November 20, 2019 20:33
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 20, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable17 in #18040

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 20, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable16 in #18041

@georgehrke georgehrke mentioned this pull request Dec 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@georgehrke georgehrke georgehrke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer @georgehrke @nickvergessen @ChristophWurst