Skip to content

Fix SMB availability status + higher delay on auth issues #16836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2019
Merged

Fix SMB availability status + higher delay on auth issues #16836

merged 3 commits into from
Sep 9, 2019

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Aug 22, 2019

Contains two fixes:
1.) sets unavailbility flag properly for SMB via php-smbclient
2.) adds a higher delay on auth issues to make a lock out on AD more unlikely

fixes #16724

blizzz added 2 commits August 22, 2019 11:12
@blizzz
catch auth issues also when php-smbclient is in use
cd62b38 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
set a storage availability delay on auth issues to avoid lock out
43bc31b 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 17 milestone Aug 22, 2019
@blizzz
Copy link
Member Author

blizzz commented Aug 22, 2019

/backport to stable16

@blizzz
Copy link
Member Author

blizzz commented Aug 22, 2019

/backport to stable15

@blizzz blizzz changed the title Fix/16724/smb availability Fix SMB availability status + higher delay on auth issues Aug 22, 2019
@rullzer rullzer mentioned this pull request Aug 23, 2019
Merged
@kesselb kesselb mentioned this pull request Aug 25, 2019
Closed
@blizzz
adjust tests
4bd83c9 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@kesselb kesselb mentioned this pull request Aug 27, 2019
Closed
@rullzer rullzer mentioned this pull request Aug 29, 2019
Merged
16 tasks
rullzer
rullzer approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane. But I have no SMB setup to test against

@blizzz
Copy link
Member Author

blizzz commented Aug 30, 2019 •
edited
Loading

I got positive feedback from a customer, apart form a possible side effect:

One strange thing I've observed on my environment (nc 16.0.4 with your patch). When I create one new external storage mount with the webinterface its creates three mount points all with the same settings?

I'll try to reproduce it., but might be early next week if not today.

Therefore setting label to "developing".

@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 30, 2019
@blizzz
Copy link
Member Author

blizzz commented Sep 4, 2019

I'll try to reproduce it., but might be early next week if not today.

Nope, WFM.

@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 4, 2019
@rullzer rullzer modified the milestones: Nextcloud 17, Nextcloud 18 Sep 5, 2019
@rullzer
Copy link
Member

rullzer commented Sep 5, 2019

Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging.

@blizzz
Copy link
Member Author

blizzz commented Sep 6, 2019

/backport to stable17

@rullzer rullzer merged commit bf6082e into master Sep 9, 2019
@rullzer rullzer deleted the fix/16724/smb-availability branch September 9, 2019 14:50
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 9, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable16 in #17070

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 9, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #17071

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 9, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable17 in #17072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: external storage

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

external storage locks user in AD when password has changed in AD

4 participants

@blizzz @rullzer @icewind1991