Use same settings for mail share as link shares#16629
Merged
Conversation
skjnldsv
requested review from
ChristophWurst,
MorrisJobke,
danxuliu,
rullzer and
schiessle
This comment has been minimized.
This comment has been minimized.
skjnldsv
added
4. to release
ChristophWurst
approved these changes
Oct 3, 2019
danxuliu
force-pushed
the
fix/shareapi/mail-default-permissions
branch
from
81a028b to
6f42131
Compare
Member
|
Rebased on master to trigger CI again. |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/shareapi/mail-default-permissions
branch
from
6f42131 to
c49469c
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not allow the creation of mail shares if link shares are disabled (because it will fail when accessing the share afterwards anyway)
Also we should have the same checks and permissions.
Currently if you create a mail share on a folder without specifying anything default perms are applied (31) but the max perms for a link share is
OC.PERMISSION_READ | OC.PERMISSION_CREATE | OC.PERMISSION_UPDATE | OC.PERMISSION_DELETE= 15Not sure we should backport as the ui might needs fixes. But for 18 ui will fit those changes.
We do not allow editing link shares that the current user doesn't own. This is confusing and lead to errors when someone else edit a password or expiration date without the share owner knowing about it.
We only allow deletion