Skip to content

Conversation

jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Mar 12, 2019

@skjnldsv as discussed, so it looks a bit nicer. I think it was suggested by @jospoortvliet
grid view border

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added enhancement design Design, UI, UX, etc. 2. developing Work in progress labels Mar 12, 2019
@jancborchardt jancborchardt added this to the Nextcloud 17 milestone Mar 12, 2019
@jancborchardt jancborchardt changed the title Add border around previews in grid view Add border around previews Mar 12, 2019
@jancborchardt

This comment has been minimized.

@ChristophWurst

This comment has been minimized.

@jancborchardt

This comment has been minimized.

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Copy link
Member Author

Btw @Ivansss this is also the CSS code you will need for the border around the previews in the Talk app :) e1e6502

@jancborchardt jancborchardt added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 14, 2019
@jancborchardt
Copy link
Member Author

Quick review please @nextcloud/designers :)

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 14, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17017: failure

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:83
Show full log
  Scenario: Install an app from the app store                     # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:83
    Given I act as Jane                                           # ActorContext::iActAs()
    And I am logged in as the admin                               # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                                # SettingsMenuContext::iOpenTheAppsManagement()
    And I open the "Tools" section                                # AppNavigationContext::iOpenTheSection()
      Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)
    And I click on the "Antivirus for files" app                  # AppsManagementContext::iClickOnTheApp()
    And I see that the app details are shown                      # AppsManagementContext::iSeeThatTheAppDetailsAreShown()
    Then I download and enable the "Antivirus for files" app      # AppsManagementContext::iDownloadAndEnableTheApp()
    And I see that the "Antivirus for files" app has been enabled # AppsManagementContext::iSeeThatTheAppHasBeenEnabled()

TESTS=syntax-php7.3

  • git clone failure - can typically be ignored

@MorrisJobke
Copy link
Member

  • tests/acceptance/features/apps.feature:83

"fixed" in #14681

@MorrisJobke MorrisJobke merged commit 3e3d41a into master Mar 14, 2019
@MorrisJobke MorrisJobke deleted the design/grid-border branch March 14, 2019 22:31
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
@jospoortvliet
Copy link
Member

Very nice, and yeah, I suggested it as I am always taking screenshots, those have a lot of white on sides and bottom and thus look odd without a border ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants