Set User-Agent as header without middleware #14363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
debt/cleanup-httpservice
branch
2 times, most recently
from
a3f68c5 to
fd6d24b
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Get proxyuserpwd only if proxy not empty. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
debt/cleanup-httpservice
branch
from
a428996 to
fd1d853
Compare
Changed the implementation for getProxyUri with fd1d853 If proxy is already null then we don't ask for proxyuserpwd. Test failed because we expected getSystemValue to be called once with proxyuserpwd Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added
3. to review
nickvergessen
approved these changes
Apr 17, 2019
rullzer
approved these changes
Apr 17, 2019
rullzer
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server/lib/private/Http/Client/Client.php
Lines 78 to 81 in bc120bc
I was wondering about the code above because this way of setting the user agent is really complicated. Refactored the request options code a bit and removed the setDefaultOptions method. The only notable change is that it's now possible to overwrite the user agent.