Skip to content

Use the existing info from the share root to get source storage and path #10919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Use the existing info from the share root to get source storage and path #10919

wants to merge 3 commits into from

Conversation

@icewind1991
Copy link
Member

Also includes an improvement for getMountByNumericId to ensure we don't lose all the improvements we've gained there.

Saves 1 query per incoming share.

@icewind1991
use the existing info from the share root to get source storage and path
ca6072b 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
more efficient findByNumericId for mounts
cbaffde 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
handle mount not found when trying to get share source
f132162 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 29, 2018
@icewind1991 icewind1991 added this to the Nextcloud 14 milestone Aug 29, 2018
@MorrisJobke MorrisJobke mentioned this pull request Aug 30, 2018
Merged
6 tasks
@rullzer
Copy link
Member

rullzer commented Aug 30, 2018

CI fails

@rullzer rullzer modified the milestones: Nextcloud 14, Nextcloud 15 Sep 3, 2018
@MorrisJobke
Copy link
Member

CI fails

Still the case 🏓

@rullzer rullzer added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 2, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 7, 2018
Merged
29 tasks
@MorrisJobke MorrisJobke modified the milestones: Nextcloud 15, Nextcloud 16 Nov 7, 2018
@ChristophWurst ChristophWurst added 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 2. developing Work in progress labels Jan 30, 2019
@ChristophWurst
Copy link
Member

Still no update. Can we close this?

@rullzer rullzer closed this Jan 30, 2019
@ChristophWurst ChristophWurst deleted the share-reuse-rootinfo-source branch January 30, 2019 09:23
@MorrisJobke MorrisJobke removed this from the Nextcloud 16 milestone Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer Awaiting requested review from rullzer

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

0. Needs triage Pending check for reproducibility or if it fits our roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991 @rullzer @MorrisJobke @ChristophWurst