[Bug]: Redis via unix socket spams log with deprecation warning

[VolkerStolz]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

I'm running Nextcloud with a unix domain socket to a Redis server.

The log is spammed around once per second with:

Debug PHP Redis::pconnect(): Passing null to parameter #2 ($port) of type int is deprecated at /var/www/html/lib/private/RedisFactory.php#104

I've successfully tweaked the following line to use -1 instead of null as recommended by PHPRedis, and i) the warnings go away and ii) my Redis connection still works ;-)

server/lib/private/RedisFactory.php

Line 80 in 4fe0799

$port = $config['port'] ?? ($host[0] !== '/' ? 6379 : null);

Of course the alternative is to set the port to -1 in the configuration explicitly, but that seems like redundant effort and rather the default should be corrected.

Steps to reproduce

1. Configure Redis via a unix socket
2. Observe flood of Debug messages

Expected behavior

No spam in log.

Nextcloud Server version

31

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

{   
    "system": {
        "htaccess.RewriteBase": "\/",
        "apps_paths": [
            {   
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {   
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "***REMOVED SENSITIVE VALUE***"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "version": "31.0.7.1",
        "overwrite.cli.url": "http:\/\/localhost",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "overwriteprotocol": "https",
        "maintenance": false,
        "maintenance_window_start": 1,
        "app_install_overwrite": [
            "epubreader",
            "cookbook",
            "files_texteditor",
            "news"
        ],
        "loglevel": 0,
        "default_phone_region": "DE",
        "mail_smtpmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_sendmailmode": "smtp",
        "mail_smtpport": "25",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "memories.exiftool": "\/var\/www\/html\/custom_apps\/memories\/bin-ext\/exiftool-amd64-glibc",
        "memories.vod.path": "\/var\/www\/html\/custom_apps\/memories\/bin-ext\/go-vod-amd64",
        "enabledPreviewProviders": [
            "OC\\Preview\\Image",
            "OC\\Preview\\HEIC",
            "OC\\Preview\\TIFF"
        ],
        "memories.gis_type": 2,
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "redis": {
            "host": "/var/run/redis-server.sock",
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "mail_smtpsecure": "",
        "mail_smtpauth": false,
        "mail_smtpauthtype": "PLAIN",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***"
    }
}

List of activated Apps

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

Additional info

No response

[joshtrichards]

Thanks for the report!

I guess this typically doesn't come up because we document setting port to 0 when using a UNIX socket:

https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/caching_configuration.html#connecting-to-single-redis-server-over-unix-socket

The phpredis docs have it both ways. The -1 you found then 0 in their example:

https://github.com/phpredis/phpredis/blob/d0b0c5cfdde9d49a265ca4bf7184e3998863aed0/README.md?plain=1#L275

;)

Based on a really quick glance at some of their code, both are used and many checks are just >0.

Main thing it shouldn't be null. I guess we should pick either 0 or -1 and go with it.