-
-
Couldn't load subscription status.
- Fork 4.6k
Description
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
PR #52511 implements the ability to show in Internal Shares all federated shares.
In certain contexts (federation with non-trusted servers AND trusted servers (e.g. global scale)):
- having shares to untrusted servers appearing in Internal shares section will be an issue
- having shares to users from the lookup server appearing in the External share section will be an issue as well
Describe the solution you'd like
A new setting that would allow federated shares to trusted servers to appear in the Internal share section. Something like show_federated_shares_to_trusted_servers_as_internal.
Describe alternatives you've considered
-/-
Additional context
In some cases it is expected that shares from users from the lookup server end up in the internal sharing section. However, if shares from users **outside ** of the lookup server appear in the internal sharing section, we expect users to be puzzled (see image below).
Further thoughts
- seeing cloudIDs e.g.
alice@nc1.local.mlh.ovhin the internal shares will looks weird - seeing regular display names e.g.
bobin external shares can have some sense in certain conditions.
With a logic table:
| Server of recipient is trusted ? | Recipient's displayName can be fetched from lookup server ? | Location of the share in the UI | Comment |
|---|---|---|---|
| 0 | 0 | External | Share to untrusted servers should always appear in external shares |
| 0 | 1 | External | Share to untrusted servers should always appear in external shares |
| 1 | 0 | depending on setting ? | I am torn, at first glance, I would say external because it looks weird to have cloudIDs in internal shares, but if for some reason the lookup server is gone, that might be useful |
| 1 | 1 | depending on setting |
