-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Closed
Enhancement
Copy link
Labels
0. Needs triagePending check for reproducibility or if it fits our roadmapPending check for reproducibility or if it fits our roadmapenhancement
Description
Is your feature request related to a problem? Please describe.
Currently the use of author or label fields is referenced without constants:
| $this->versionManager->setMetadataValue($node, $node->getMTime(), 'author', $author); |
| $propFind->handle(self::VERSION_LABEL, fn () => $node->getMetadataValue('label')); |
| $propFind->handle(self::VERSION_AUTHOR, fn () => $node->getMetadataValue('author')); |
| $propPatch->handle(self::VERSION_LABEL, fn (string $label) => $node->setMetadataValue('label', $label)); |
Describe the solution you'd like
In my app I set by code through IVersionManager the label metadata value and I would like the reference to be more secure through that constant.
I can create a PR if you approve.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Metadata
Metadata
Assignees
Labels
0. Needs triagePending check for reproducibility or if it fits our roadmapPending check for reproducibility or if it fits our roadmapenhancement