Skip to content

Invalid "login_credentials" with passwordless login #46300

Open

Description

Steps to reproduce:

  • Login with a webauthn device
  • IStore.getLoginCredentials returns an array with a username and an empty password.

Technical debt

Code using getLoginCredentials has to check for null or empty string and also a couple of exceptions1.

Better: throw PasswordUnavailableException and have a clear way to signal a passwordless login.

Related: #35878

Footnotes

  1. https://github.com/nextcloud/mail/blob/2c0c029add36db0791d8a92f4a766e24fca2d38a/lib/Controller/PageController.php#L180-L181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions