Unify "Hide download" for public share and "Allow download" behavior for user share + provide possibility to configure it

[Koc]

I've just realized that there is some inconsistency between sharing for concrete user and public link.

🔍 Public share has "Hide download" checkbox

🔍 At the same time sharing for concrete user has inversed logic "Allow download"

It would be nice to unify behavior and provide same experience for both public and user shares for better consistency.
Also there is possibility to change default permission for a new share. But there is no way to disable download for new shared. Can we add this option?

Related to #45412.

[sorbaugh]

@marcoambrosini clearing this up would allow us to know how to deal correctly with several bugs that are open at the moment. Can you check this from a design perspective which would be the way to go?

[jancborchardt]

Indeed it makes sense to use the same wording for both. "Hide download" would make most sense because then none of the optional checkboxes are checked by default.

[susnux]

@jancborchardt it is not really only about the visual representation. The question we need to be answered by product design is:

Should we keep offering two different functionalities.

If yes:

• Allow both for both sharing types?
• Keep behavior of 30 and below of having "hide download" on public shares which still allows download but just hides the download button and "prevent download" on internal shares (no download at all - only online viewing in office apps).

If no:

• Which one to keep?

From what we have on requests (see also internal ticket) it seems we need both variants for both sharing types.
Or we just decide we do not want this and keep only one consistent.