[Bug]: Internal server error after upgrade to NC25beta: Typed property OC\Files\Storage\Wrapper\Quota::$quota must be int or null, float used in file

[lars-becker]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• Nextcloud Server is running on 64bit capable CPU, PHP and OS.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

After an upgrade to NC25 Beta 6 from NC24 Nextcloud throws an 500 internal server error for logged in users. I switched the debug level to 0, but wasn't unable to finde more information than this trace which doesn't help me to get an idea, what might trigger the problem.

Technische Details

    Entfernte Adresse: *.*.*.*
    Anfragekennung: VCfmkYXxYwbhOMWqG9E4
    Typ: Exception
    Code: 0
    Nachricht: Return value of OC\Files\Storage\Wrapper\Quota::getQuota() must be of the type int, float returned in file '/var/www/nextcloud/lib/private/Files/Storage/Wrapper/Quota.php' line 70
    Datei: /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php
    Zeile: 165


Trace

#0 /var/www/nextcloud/lib/private/AppFramework/App.php(172): OC\AppFramework\Http\Dispatcher->dispatch()
#1 /var/www/nextcloud/lib/private/Route/Router.php(298): OC\AppFramework\App::main()
#2 /var/www/nextcloud/lib/base.php(1047): OC\Route\Router->match()
#3 /var/www/nextcloud/index.php(36): OC::handleRequest()
#4 {main}


Vorige

#0 /var/www/nextcloud/lib/private/Files/Storage/Wrapper/Quota.php(74): OC\Files\Storage\Wrapper\Quota->getQuota()
#1 /var/www/nextcloud/lib/private/Files/Storage/Wrapper/Quota.php(110): OC\Files\Storage\Wrapper\Quota->hasQuota()
#2 /var/www/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php(334): OC\Files\Storage\Wrapper\Quota->free_space()
#3 /var/www/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php(334): OC\Files\Storage\Wrapper\Wrapper->free_space()
#4 /var/www/nextcloud/lib/private/Files/View.php(1171): OC\Files\Storage\Wrapper\Wrapper->free_space()
#5 /var/www/nextcloud/lib/private/Files/View.php(1117): OC\Files\View->basicOperation()
#6 /var/www/nextcloud/lib/private/Files/Node/Folder.php(383): OC\Files\View->free_space()
#7 /var/www/nextcloud/apps/spreed/lib/TInitialState.php(137): OC\Files\Node\Folder->getFreeSpace()
#8 /var/www/nextcloud/apps/spreed/lib/Files/TemplateLoader.php(97): OCA\Talk\Files\TemplateLoader->publishInitialStateForUser()
#9 /var/www/nextcloud/lib/private/EventDispatcher/ServiceEventListener.php(87): OCA\Talk\Files\TemplateLoader->handle()
#10 /var/www/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php(251): OC\EventDispatcher\ServiceEventListener->__invoke()
#11 /var/www/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php(73): Symfony\Component\EventDispatcher\EventDispatcher->callListeners()
#12 /var/www/nextcloud/lib/private/EventDispatcher/EventDispatcher.php(88): Symfony\Component\EventDispatcher\EventDispatcher->dispatch()
#13 /var/www/nextcloud/lib/private/EventDispatcher/EventDispatcher.php(100): OC\EventDispatcher\EventDispatcher->dispatch()
#14 /var/www/nextcloud/apps/dashboard/lib/Controller/DashboardController.php(99): OC\EventDispatcher\EventDispatcher->dispatchTyped()
#15 /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php(225): OCA\Dashboard\Controller\DashboardController->index()
#16 /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php(133): OC\AppFramework\Http\Dispatcher->executeController()
#17 /var/www/nextcloud/lib/private/AppFramework/App.php(172): OC\AppFramework\Http\Dispatcher->dispatch()
#18 /var/www/nextcloud/lib/private/Route/Router.php(298): OC\AppFramework\App::main()
#19 /var/www/nextcloud/lib/base.php(1047): OC\Route\Router->match()
#20 /var/www/nextcloud/index.php(36): OC::handleRequest()
#21 {main}

Steps to reproduce

Haven't tried to reproduce it on other instances. Error occured directly after installing Beta5 with the web installer. Tried to upgrade to Beta6 with a manual upgrade. Nothing changed.

Expected behavior

200 OK instead of 500 Internal Server Error.

Installation method

Community Manual installation with Archive

Operating system

Debian/Ubuntu

PHP engine version

PHP 7.4

Web server

Nginx

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Updated to a major version (ex. 22.2.3 to 23.0.1)

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

{                                                 
    "system": {                
        "maintenance": false, 
        "config_is_read_only": false,
        "installed": true,                
        "version": "25.0.0.11",
        "share_folder": "\/Shared\/",
        "sharing.maxAutocompleteResults": 50,
        "sharing.minSearchStringLength": 2,       
        "sharing.enable_share_accept": true,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",    
            "port": 6379        
        },                      
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",    
        "dbtableprefix": "oc_",                   
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "forcessl": true,       
        "blacklisted_files": [
            ".htaccess"                       
        ],            
        "theme": "",               
        "default_language": "de",
        "3rdpartyroot": "", 
        "3rdpartyurl": "",                                                                                                                                                                                                             [44/384]
        "defaultapp": "apporder",
        "knowledgebaseenabled": false,
        "knowledgebaseurl": "https:\/\/api.owncloud.com\/v1",
        "appstoreenabled": true,
        "appstoreurl": "https:\/\/apps.nextcloud.com\/api\/v1",
        "activity_expire_days": 186,
        "mail_smtpdebug": false,
        "mail_smtpmode": "sendmail",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "mail_smtptimeout": 10,
        "mail_smtpauthtype": "LOGIN",
        "trashbin_retention_obligation": "180, auto",
        "versions_retention_obligation": "30,auto",
        "allow_user_to_change_display_name": true,
        "appcodechecker": true,
        "updatechecker": true,
        "log_type": "file",
        "logfile": "\/tmp\/nextcloud.log",
        "logfilemode": 416,
        "loglevel": 0,
        "syslog_tag": "Nextcloud",
        "remember_login_cookie_lifetime": 1209600,
        "session_lifetime": 86400,
        "xframe_restriction": true,
        "apps_paths": [
            {
                "path": "\/var\/www\/nextcloud\/apps\/",
                "url": "\/apps",
                "writable": true
            }
        ],
        "customclient_desktop": "",
        "customclient_android": "",
        "customclient_ios": "",
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***.org"
        ],
        "appstore.experimental.enabled": true,
        "debug": true,
        "log_rotate_size": 1048576,
        "singleuser": false,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mysql.utf8mb4": true,
       "updater.release.channel": "beta",
        "preview_libreoffice_path": "\/usr\/bin\/libreoffice",
        "enable_previews": true,
        "preview_max_x": 800,
        "preview_max_y": 800,
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\GIF",
            "OC\\Preview\\HEIC",
            "OC\\Preview\\BMP",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\MP3",
            "OC\\Preview\\TXT",
            "OC\\Preview\\MarkDown",
            "OC\\Preview\\OpenDocument",
            "OC\\Preview\\Krita",
            "OC\\Preview\\MSOffice2003",
            "OC\\Preview\\MSOffice2007",
            "OC\\Preview\\MSOfficeDoc",
            "OC\\Preview\\PDF",
            "OC\\Preview\\Postscript",
            "OC\\Preview\\StarOffice",
            "OC\\Preview\\SVG",
            "OC\\Preview\\Font"
        ],
        "twofactor_enforced": "false",
        "twofactor_enforced_groups": [],
        "twofactor_enforced_excluded_groups": [],
        "skeletondirectory": "",
        "app_install_overwrite": {
            "25": "bbb"
        },
        "overwrite.cli.url": "https:\/\/***.org",
        "data-fingerprint": "7921b76ed34d1840b29754d584250194",
        "logtimezone": "Europe\/Berlin",
        "activity_use_cached_mountpoints": true,
        "has_rebuilt_cache": true,
        "simpleSignUpLink.shown": true,
        "default_phone_region": "DE",
        "updater.secret": "***REMOVED SENSITIVE VALUE***"
    }
}

List of activated Apps

Enabled:                 
  - activity: 2.17.0   
  - calendar: 3.5.0           
  - circles: 25.0.0-alpha.0
  - cloud_federation_api: 1.8.0
  - comments: 1.15.0
  - contacts: 4.2.0 
  - contactsinteraction: 1.6.0
  - dashboard: 7.5.0 
  - dav: 1.24.0       
  - federatedfilesharing: 1.15.0
  - federation: 1.15.0
  - files: 1.20.0  
  - files_lock: 24.0.1
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - files_videoplayer: 1.14.0
  - integration_github: 1.0.4           
  - integration_gitlab: 1.0.6       
  - integration_twitter: 1.0.3 
  - logreader: 2.10.0             
  - lookup_server_connector: 1.13.0
  - maps: 0.2.1               
  - notifications: 2.13.1
  - oauth2: 1.13.0              
  - password_policy: 1.15.0
  - photos: 1.7.0           
  - privacy: 1.9.0        
  - provisioning_api: 1.15.0
  - serverinfo: 1.15.0     
  - settings: 1.7.0             
  - spreed: 15.0.0-beta.3      
  - survey_client: 1.13.0 
  - systemtags: 1.15.0       
  - text: 3.6.0
  - theming: 2.0.0
  - twofactor_backupcodes: 1.14.0
  - twofactor_totp: 6.4.0
  - updatenotification: 1.15.0
  - user_status: 1.5.0
  - viewer: 1.9.0
  - weather_status: 1.5.0
  - workflowengine: 2.7.0

Nextcloud Signing status

No response

Nextcloud Logs

see above

Additional info

No response

[solracsf]

Can you manually modify file /var/www/nextcloud/lib/private/Files/Storage/Wrapper/Quota.php line 70 from

return $this->quota;

to

return (int) $this->quota;

and see if it helps?

[lars-becker]

Thanks for the quick fix. I applied the patch and everything works as expected.

[CarlSchwan]

Thanks for the quick fix. I applied the patch and everything works as expected.

Thanks for testing 😀

[Zorugal]

Is it possible, that this fix broke 32-bit compatibility again?

I just upgraded to 25.0.2 on my ARMv7 server (32 bit) and got this error:

{"reqId":"Y5LcXi2Re-ghOYkJ5MvebgAAAAE","level":3,"time":"2022-12-09T06:57:37+00:00","remoteAddr":"X.X.X.X","user":"Name","app":"index","method":"GET","url":"/index.php/apps/files/","message":"Cannot assign float to property OC\\Files\\Storage\\Wrapper\\Quota::$quota of type ?int in file '/var/www/nextcloud/lib/private/Files/Storage/Wrapper/Quota.php' line 68","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0","version":"25.0.2.3","exception":{"Exception":"Exception","Message":"Cannot assign float to property OC\\Files\\Storage\\Wrapper\\Quota::$quota of type ?int in file '/var/www/nextcloud/lib/private/Files/Storage/Wrapper/Quota.php' line 68","Code":0,"Trace":[{"file":"/var/www/nextcloud/lib/private/AppFramework/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/nextcloud/lib/private/Route/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/var/www/nextcloud/lib/base.php","line":1047,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/var/www/nextcloud/index.php","line":36,"function":"handleRequest","class":"OC","type":"::"}],"File":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","Line":165,"Previous":{"Exception":"TypeError","Message":"Cannot assign float to property OC\\Files\\Storage\\Wrapper\\Quota::$quota of type ?int","Code":0,"Trace":[{"function":"getQuota","class":"OC\\Files\\Storage\\Wrapper\\Quota","type":"->"},{"file":"/var/www/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php","line":527,"function":"call_user_func_array"},{"file":"/var/www/nextcloud/lib/private/legacy/OC_Helper.php","line":518,"function":"__call","class":"OC\\Files\\Storage\\Wrapper\\Wrapper","type":"->"},{"file":"/var/www/nextcloud/apps/files/lib/Controller/ViewController.php","line":155,"function":"getStorageInfo","class":"OC_Helper","type":"::"},{"file":"/var/www/nextcloud/apps/files/lib/Controller/ViewController.php","line":205,"function":"getStorageInfo","class":"OCA\\Files\\Controller\\ViewController","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":225,"function":"index","class":"OCA\\Files\\Controller\\ViewController","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":133,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/nextcloud/lib/private/Route/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/var/www/nextcloud/lib/base.php","line":1047,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/var/www/nextcloud/index.php","line":36,"function":"handleRequest","class":"OC","type":"::"}],"File":"/var/www/nextcloud/lib/private/Files/Storage/Wrapper/Quota.php","Line":68},"CustomMessage":"--"}}

Changing the type of quota from int to float in Files/Storage/Wrapper/Quota.php seems to fix the problem.

[paulbastian]

+1 same for me

[juliani-77]

could you please post what did you change; filenames, nr. of line and the edited content - it what be very helpful!
thanks in advance.
thats what my server showing:
Error | webdav | TypeError: Cannot assign float to property OC\Files\Storage\Wrapper\Quota::$quota of type ?int<>OC\Files\Storage\Wrapper\Quota->getQuota()/var/www/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php - line 527:call_user_func_array()
......

[paulbastian]

TypeError: Cannot assign float to property OC\Files\Storage\Wrapper\Quota::$quota of type ?int

<<closure>>

OC\Files\Storage\Wrapper\Quota->getQuota()

/usr/share/nginx/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php - line 527:

call_user_func_array()