Description
- mark a file as favorite via WebDAV (Android or iOS app for example)
- open the activity view
- expected: "You have favorited FILE"
- actual: no activity
The web UI uses apps/files/api/v1/files/FILE
API that does trigger the activity.
The code to add the tag:
server/apps/files/lib/Service/TagService.php
Lines 85 to 112 in d89a75b
And then the actitivity:
server/apps/files/lib/Service/TagService.php
Lines 119 to 148 in d89a75b
While the PROPPATCH doesn't trigger anything related to that:
server/apps/dav/lib/Connector/Sabre/TagsPlugin.php
Lines 284 to 295 in eb502c0
How to handle this? The ugly way by making tthe method in TagService
public and call from the dav app directly into the files app to have it all in one place, or to copy it over and deprecated the files app approach as we should go for DAV based API access anyways? I would say option 2.
cc @rullzer @ChristophWurst @kesselb @PVince81 @juliushaertl
Activity