Since the upgrade from Owncloud to Nextcloud (11 and later), not all groups resolve

[gvansanden]

We are using Nextcloud on Ubuntu 16.04 against OpenLDAP

Steps to reproduce

1. Install Nextcloud 11 or later
   2.Point to openldap

Expected behaviour

All groups resolve as before

Actual behaviour

Only a limited amount of groups resolve, command line listing ends in a timeout error after a long time

Server configuration

Operating system:
Ubuntu server 16.04 LTS

Web server:
Apache2

Database:
MySQL

PHP version:
7.0.15

Nextcloud version: (see Nextcloud admin page)
13.0.5 (any version since 11

Updated from an older Nextcloud/ownCloud or fresh install:
update from NC 11

Where did you install Nextcloud from:
tar file

Issue fixed by editing apps/user_ldap/lib/Group_LDAP.php
change line 831 from
str_replace('%uid', $member, $this->access->connection->ldapLoginFilter),
to
str_replace('%uid', trim($member), $this->access->connection->ldapLoginFilter),

The trim fixes it

[nextcloud-bot]

GitMate.io thinks possibly related issues are #4464 (Random LDAP issue after upgrading to owncloud/nextcloud), #104 (NextCloud / OwnCloud), #4721 (Cannot Upgrade from Owncloud 10.0.0.12 to Nextcloud 11.0.3), #96 (Last message during upgrade says ownCloud instead of Nextcloud), and #3109 (Unable to send e-mail since Nextcloud 11).

[rullzer]

@nextcloud/ldap

[blizzz]

@gvansanden since you have the fix at hand, could you open a pull request? :)

[MorrisJobke]

@gvansanden since you have the fix at hand, could you open a pull request? :)

See #10775