Skip to content

Commit fe7b603

Browse files
committed
fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optional
Signed-off-by: provokateurin <kate@provokateurin.de>
1 parent 10aeb95 commit fe7b603

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

apps/files_external/lib/Lib/Auth/Password/LoginCredentials.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,9 @@ public function __construct(
8181
->setText($l->t('Log-in credentials, save in database'))
8282
->addParameters([
8383
(new DefinitionParameter('password', $l->t('Password')))
84-
->setType(DefinitionParameter::VALUE_PASSWORD),
84+
->setType(DefinitionParameter::VALUE_PASSWORD)
85+
->setFlag(DefinitionParameter::FLAG_HIDDEN)
86+
->setFlag(DefinitionParameter::FLAG_OPTIONAL),
8587
]);
8688

8789
$eventDispatcher->addServiceListener(UserLoggedInEvent::class, StorePasswordListener::class);

apps/files_external/lib/Lib/Auth/Password/SessionCredentials.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,9 @@ public function __construct(IL10N $l, CredentialsStore $credentialsStore) {
5151
->setText($l->t('Log-in credentials, save in session'))
5252
->addParameters([
5353
(new DefinitionParameter('password', $l->t('Password')))
54-
->setType(DefinitionParameter::VALUE_PASSWORD),
54+
->setType(DefinitionParameter::VALUE_PASSWORD)
55+
->setFlag(DefinitionParameter::FLAG_HIDDEN)
56+
->setFlag(DefinitionParameter::FLAG_OPTIONAL),
5557
]);
5658
}
5759

0 commit comments

Comments
 (0)