Merge pull request #31415 from knox/fix-opcache-permitted-path

MichaIng · web-flow · commit fdf4024ccb29 · 2022-03-04T00:38:00.000+01:00
Fix "Nextcloud is not allowed to use the OPcache API" warning
diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php
@@ -477,7 +477,7 @@ protected function getOpcacheSetupRecommendations(): array {
 		// Check whether Nextcloud is allowed to use the OPcache API
 		$isPermitted = true;
 		$permittedPath = $this->iniGetWrapper->getString('opcache.restrict_api');
-		if (isset($permittedPath) && $permittedPath !== '' && !str_starts_with(\OC::$SERVERROOT, $permittedPath)) {
+		if (isset($permittedPath) && $permittedPath !== '' && !str_starts_with(\OC::$SERVERROOT, rtrim($permittedPath, '/'))) {
 			$isPermitted = false;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -477,7 +477,7 @@ protected function getOpcacheSetupRecommendations(): array {`
`477`	`477`	`// Check whether Nextcloud is allowed to use the OPcache API`
`478`	`478`	`$isPermitted = true;`
`479`	`479`	`$permittedPath = $this->iniGetWrapper->getString('opcache.restrict_api');`
`480`		`- if (isset($permittedPath) && $permittedPath !== '' && !str_starts_with(\OC::$SERVERROOT, $permittedPath)) {`
	`480`	`+ if (isset($permittedPath) && $permittedPath !== '' && !str_starts_with(\OC::$SERVERROOT, rtrim($permittedPath, '/'))) {`
`481`	`481`	`$isPermitted = false;`
`482`	`482`	`}`
`483`	`483`