fix: filter out contacts with invalid email addresses in sharee completion

juliusknorr · backportbot[bot] · commit fbb75c5a24eb · 2025-03-25T22:43:46.000Z
Signed-off-by: Julius Knorr &lt;jus@bitgrid.net&gt;
diff --git a/lib/private/Collaboration/Collaborators/MailPlugin.php b/lib/private/Collaboration/Collaborators/MailPlugin.php
@@ -121,6 +121,11 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b
 						$emailAddress = $emailAddressData['value'];
 						$emailAddressType = $emailAddressData['type'];
 					}
+
+					if (!filter_var($emailAddress, FILTER_VALIDATE_EMAIL)) {
+						continue;
+					}
+
 					if (isset($contact['FN'])) {
 						$displayName = $contact['FN'] . ' (' . $emailAddress . ')';
 					}

Original file line number	Diff line number	Diff line change
`@@ -121,6 +121,11 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b`
`121`	`121`	`$emailAddress = $emailAddressData['value'];`
`122`	`122`	`$emailAddressType = $emailAddressData['type'];`
`123`	`123`	`}`
	`124`	`+`
	`125`	`+ if (!filter_var($emailAddress, FILTER_VALIDATE_EMAIL)) {`
	`126`	`+ continue;`
	`127`	`+ }`
	`128`	`+`
`124`	`129`	`if (isset($contact['FN'])) {`
`125`	`130`	`$displayName = $contact['FN'] . ' (' . $emailAddress . ')';`
`126`	`131`	`}`