fix(Image): Do not send empty Content-Type header

come-nc · come-nc · commit f296d19832b0 · 2024-08-29T10:06:20.000+02:00
Signed-off-by: Côme Chilliet &lt;come.chilliet@nextcloud.com&gt;
diff --git a/lib/private/Image.php b/lib/private/Image.php
@@ -166,7 +166,9 @@ public function show(?string $mimeType = null): bool {
 		if ($mimeType === null) {
 			$mimeType = $this->mimeType();
 		}
-		header('Content-Type: ' . ($mimeType ?? ''));
+		if ($mimeType !== null) {
+			header('Content-Type: ' . $mimeType);
+		}
 		return $this->_output(null, $mimeType);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,9 @@ public function show(?string $mimeType = null): bool {`
`166`	`166`	`if ($mimeType === null) {`
`167`	`167`	`$mimeType = $this->mimeType();`
`168`	`168`	`}`
`169`		`- header('Content-Type: ' . ($mimeType ?? ''));`
	`169`	`+ if ($mimeType !== null) {`
	`170`	`+ header('Content-Type: ' . $mimeType);`
	`171`	`+ }`
`170`	`172`	`return $this->_output(null, $mimeType);`
`171`	`173`	`}`
`172`	`174`