more efficient unique share target generation

Signed-off-by: Robin Appelman <robin@icewind.nl>

Author: icewind1991

apps/files_sharing/lib/MountProvider.php

@@ -86,7 +86,7 @@ public function getMountsForUser(IUser $user, IStorageFactory $storageFactory) {
 		$mounts = [];
 		foreach ($superShares as $share) {
 			try {
-				$mounts[] = new SharedMount(
+				$mount = new SharedMount(
 					'\OCA\Files_Sharing\SharedStorage',
 					$mounts,
 					[
@@ -98,14 +98,15 @@ public function getMountsForUser(IUser $user, IStorageFactory $storageFactory) {
 					],
 					$storageFactory
 				);
+				$mounts[$mount->getMountPoint()] = $mount;
 			} catch (\Exception $e) {
 				$this->logger->logException($e);
 				$this->logger->error('Error while trying to create shared mount');
 			}
 		}
 
 		// array_filter removes the null values from the array
-		return array_filter($mounts);
+		return array_values(array_filter($mounts));
 	}
 
 	/**

apps/files_sharing/lib/SharedMount.php

@@ -135,18 +135,8 @@ private function generateUniqueTarget($path, $view, array $mountpoints) {
 		$name = $pathinfo['filename'];
 		$dir = $pathinfo['dirname'];
 
-		// Helper function to find existing mount points
-		$mountpointExists = function ($path) use ($mountpoints) {
-			foreach ($mountpoints as $mountpoint) {
-				if ($mountpoint->getShare()->getTarget() === $path) {
-					return true;
-				}
-			}
-			return false;
-		};
-
 		$i = 2;
-		while ($view->file_exists($path) || $mountpointExists($path)) {
+		while ($view->file_exists($path) || isset($mountpoints[$path])) {
 			$path = Filesystem::normalizePath($dir . '/' . $name . ' (' . $i . ')' . $ext);
 			$i++;
 		}