Merge pull request #30281 from nextcloud/bugfix/30280/fix-confused-notifier-with-null-group

PVince81 · web-flow · commit e23133887644 · 2021-12-17T08:01:55.000+01:00
Ignore non-existing groups when notifying group shares
diff --git a/apps/files_sharing/lib/Notification/Notifier.php b/apps/files_sharing/lib/Notification/Notifier.php
@@ -192,7 +192,7 @@ protected function parseShareInvitation(IShare $share, INotification $notificati
 				}
 
 				$group = $this->groupManager->get($share->getSharedWith());
-				if (!$group->inGroup($user)) {
+				if ($group === null || !$group->inGroup($user)) {
 					throw new AlreadyProcessedException();
 				}
 

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ protected function parseShareInvitation(IShare $share, INotification $notificati`
`192`	`192`	`}`
`193`	`193`
`194`	`194`	`$group = $this->groupManager->get($share->getSharedWith());`
`195`		`- if (!$group->inGroup($user)) {`
	`195`	`+ if ($group === null \|\| !$group->inGroup($user)) {`
`196`	`196`	`throw new AlreadyProcessedException();`
`197`	`197`	`}`
`198`	`198`